-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant script from Travis build and improve log information #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrutkows
changed the title
Improve Travis build log information
Remove redundant script from Travis build and improve log information
Apr 1, 2021
While here, tried to address our ability to debug recurring issues we have seen for a very long time only in Travis around doing large project exports (esp. with project dependencies) in rapid succession by adding additional error checking and trace capabilities around the ExportProject test entry point (and its fulfilling code). |
dgrove-oss
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reviewing this PR: #1137 I found something unexpected...
Although the PR itself was attempting to add arm64 support (aka aarch64); we knew that arm64 was being already being built and released without any code in that script .
I determined that we had a script that was not doing what it was named for...
https://github.com/apache/openwhisk-wskdeploy/blob/master/tools/travis/build_tag_releases.sh
and was not accounted for properly (i.e., removed) when gogradle support was added and then subsequently improved over time.
History
The original support of gogradle was added here (no "build_tag_release.sh):
#812
which removed the script in question:
later the same day it was added back (with no reason provided):
#814
with the comment/title: "Keep the date update-to-date when the tag latest is updated"
Note that:
It was specifically removed here "Remove the redundant packages from the release artifacts":
#934
BUT, then it was explicitly added back here "Add the build_tag_release script back":
#936
Thankfully, Anthony added support for the LDFLAGS here:
https://github.com/apache/openwhisk-wskdeploy/pull/1047/files
which made any part of the very questionable script rendered defunct.