Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant script from Travis build and improve log information #1140

Merged
merged 12 commits into from
Apr 7, 2021

Conversation

mrutkows
Copy link
Contributor

@mrutkows mrutkows commented Mar 29, 2021

In reviewing this PR: #1137 I found something unexpected...
Although the PR itself was attempting to add arm64 support (aka aarch64); we knew that arm64 was being already being built and released without any code in that script .

I determined that we had a script that was not doing what it was named for...
https://github.com/apache/openwhisk-wskdeploy/blob/master/tools/travis/build_tag_releases.sh

and was not accounted for properly (i.e., removed) when gogradle support was added and then subsequently improved over time.

History

The original support of gogradle was added here (no "build_tag_release.sh):
#812

which removed the script in question:

- export build_file_name=wskdeploy
- go get github.com/inconshreveable/mousetrap
- "./tools/travis/build_tag_releases.sh $build_file_name"
- export RELEASE_PKG_FILE=$(ls $build_file_name-*.*)

later the same day it was added back (with no reason provided):
#814
with the comment/title: "Keep the date update-to-date when the tag latest is updated"

before_deploy:
- export build_file_name=wskdeploy
- go get github.com/inconshreveable/mousetrap
- "./tools/travis/build_tag_releases.sh $build_file_name"
- ./gradlew --console=plain releaseBinaries

Note that:

  • This seems like perhaps a failure to rebase after the first PR was merged?
  • gradlew is invoked AFTER the bash script
  • gradlew has no command line args to set the version/date/commit (yet)
  • if we remove the bash script, we can remove the export and "go get" of "mousetrap"

It was specifically removed here "Remove the redundant packages from the release artifacts":
#934

  • Before this the Bash script was before gradlew

BUT, then it was explicitly added back here "Add the build_tag_release script back":
#936

  • THIS is the PR that added the Bash script AFTER gradlew!!!
  • My guess is that was only added back to get the build version added back to the build

Thankfully, Anthony added support for the LDFLAGS here:
https://github.com/apache/openwhisk-wskdeploy/pull/1047/files

LDFLAGS=-ldflags "-X main.Version=${VERSION} -X main.GitCommit=${BUILD} -X main.BuildDate=${BUILD_DATE} -X main.Build=`git rev-parse HEAD` "

which made any part of the very questionable script rendered defunct.

@mrutkows mrutkows changed the title Improve Travis build log information Remove redundant script from Travis build and improve log information Apr 1, 2021
@mrutkows
Copy link
Contributor Author

mrutkows commented Apr 6, 2021

While here, tried to address our ability to debug recurring issues we have seen for a very long time only in Travis around doing large project exports (esp. with project dependencies) in rapid succession by adding additional error checking and trace capabilities around the ExportProject test entry point (and its fulfilling code).

@mrutkows mrutkows self-assigned this Apr 6, 2021
@mrutkows mrutkows marked this pull request as ready for review April 6, 2021 21:26
@mrutkows mrutkows merged commit ff6238d into apache:master Apr 7, 2021
@mrutkows mrutkows deleted the arm64 branch April 7, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants